dbeaver/pro#9222 validate data transfer by using product settings#4394
Open
yagudin10 wants to merge 2 commits into
Open
dbeaver/pro#9222 validate data transfer by using product settings#4394yagudin10 wants to merge 2 commits into
yagudin10 wants to merge 2 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
HocKu7
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CloudBeaver server-side data transfer (export/import) permission validation, aligning behavior with product settings (notably for Community edition) and tightening some null-safety/parameter handling.
Changes:
- Add export permission validation using Community product settings (with admin override) and block export when disabled.
- Add import restriction based on Community product settings and adjust servlet-side validation.
- Add nullability annotations and defensive checks for missing data transfer processors; introduce legacy preference keys in
CBConstants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
server/bundles/io.cloudbeaver.service.data.transfer/src/io/cloudbeaver/service/data/transfer/impl/WebServiceDataTransfer.java |
Adds export permission validation via product settings, validates processor IDs, and refines nullability annotations. |
server/bundles/io.cloudbeaver.service.data.transfer/src/io/cloudbeaver/service/data/transfer/impl/WebDataTransferImportServlet.java |
Adds product-settings-based import disabling logic (Community) and refactors permission check into a helper. |
server/bundles/io.cloudbeaver.service.data.transfer/src/io/cloudbeaver/service/data/transfer/DBWServiceDataTransfer.java |
Adds nullability annotations and requires global export permission for export actions. |
server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/server/CBConstants.java |
Adds legacy preference keys for import/export disable flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return; | ||
| } | ||
| if (!session.hasGlobalPermission(DBWConstants.GLOBAL_PERMISSION_DATA_EDITOR_IMPORT)) { | ||
| if (validateImportPermission(session)) { |
Comment on lines
+140
to
+146
| private boolean validateImportPermission(@NotNull WebSession session) { | ||
| if (WebAppUtils.getWebApplication().isCommunity()) { | ||
| Map<String, Object> productSettings = WebAppUtils.getWebApplication().getServerConfiguration().getProductSettings(); | ||
| return JSONUtils.getBoolean(productSettings, CBConstants.PREF_DATA_EDITOR_IMPORT_DISABLED_OLD, false); | ||
| } | ||
| return !session.hasGlobalPermission(DBWConstants.GLOBAL_PERMISSION_DATA_EDITOR_IMPORT); | ||
| } |
| @NotNull DataTransferProcessorDescriptor processor, | ||
| @NotNull DBSDataContainer dataContainer, | ||
| @NotNull WebDataTransferParameters parameters, | ||
| @NotNull WebSQLResultsInfo resultsInfo, |
Comment on lines
+235
to
+236
| @NotNull | ||
| public WebAsyncTaskInfo asyncImportDataContainer( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.