Skip to content

Add more URL constants#1659

Merged
rolandwalker merged 1 commit intomainfrom
RW/add-more-url-constants
Feb 28, 2026
Merged

Add more URL constants#1659
rolandwalker merged 1 commit intomainfrom
RW/add-more-url-constants

Conversation

@rolandwalker
Copy link
Contributor

@rolandwalker rolandwalker commented Feb 28, 2026

Description

Motivation: reduce typos, reduce search/replace.

Incidentally, capitalize lowercase "issue" when referring to GitHub.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 28, 2026
@github-actions
Copy link

  1. Changelog regression (duplicate release heading)
    The PR introduces a second 1.58.0 (2026/02/28) section at the top, which duplicates the existing release block and fragments entries. This should be merged into the existing 1.58.0 section instead of creating a new one.
    Reference: changelog.md:1, changelog.md:9

  2. Test gap for modified user-facing warning/help text
    Several warning/help strings were changed to use constants (HOME_URL, ISSUES_URL, REPO_URL), but there are no matching test updates to lock output format/URLs. Add assertions in CLI output tests (likely in test_main.py) for at least one --ssl deprecation warning and one --checkup/support-text path to prevent accidental regressions.
    Reference: main.py:1953, main.py:2215, main.py:2583, test_main.py

No direct security issues found in this diff.

Copy link
Contributor

@scottnemes scottnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think issue should be capitalized, but fine as-is if you prefer.

@rolandwalker rolandwalker force-pushed the RW/add-more-url-constants branch from 22ffc99 to da9da9b Compare February 28, 2026 23:28
Motivation: reduce typos, reduce search/replace.

Incidentally, lowercase "issue" when referring to GitHub/
@rolandwalker rolandwalker force-pushed the RW/add-more-url-constants branch from da9da9b to 5341382 Compare February 28, 2026 23:29
@rolandwalker rolandwalker merged commit fb56d9b into main Feb 28, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/add-more-url-constants branch February 28, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants