Open
Conversation
No new security issue stood out in this PR. |
Since some prompt escapes are expensive, and can even require a trip to the server, avoid calling get_prompt() unless needed, preferring to use the cached value in the last_prompt_message property, or a new saved value for the number of lines in the prompt. Incidentally, explicitly strip ANSI formatting from prompts before writing them to a file, when "tee" is in effect.
390db22 to
9000975
Compare
scottnemes
approved these changes
Feb 28, 2026
Contributor
scottnemes
left a comment
There was a problem hiding this comment.
get_prompt is called slightly less, but barely. So technically works.
Hitting enter 5 times causes 153 calls to get_prompt prior to this, and 152 calls with this.
Various other tests resulted in an average of 3-5 call difference. So major room for future improvement if that can be reduced.
Contributor
Author
|
Ah, so something is still very wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since some prompt escapes are expensive, and can even require a trip to the server, avoid calling
get_prompt()unless needed, preferring to use the cached value in thelast_prompt_messageproperty, or a new saved value for the number of lines in the prompt.Incidentally, explicitly strip ANSI formatting from prompts before writing them to a file, when
teeis in effect.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).