Skip to content

Complete filenames on more special commands#1652

Merged
rolandwalker merged 1 commit intomainfrom
RW/complete-filenames-all-special-commands
Feb 28, 2026
Merged

Complete filenames on more special commands#1652
rolandwalker merged 1 commit intomainfrom
RW/complete-filenames-all-special-commands

Conversation

@rolandwalker
Copy link
Contributor

Description

Although filename completion has a number of limitations currently, we should still offer it on each special command which accepts a filename, not just source.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 28, 2026
@github-actions
Copy link

Findings

  1. Case-sensitivity regression for \edit completion (low)
  • In suggest_special(), the new filename-command check uses cmd.lower().
  • \edit is registered as case-sensitive (\edit/\e, not \EDIT/\E), but completion now treats uppercase variants as valid and suggests filenames for invalid commands.
  • Action: check cmd directly for case-sensitive commands (or split case-sensitive vs case-insensitive branches).
  1. Missing test coverage for newly added commands (low)

Security

  • No new security issues identified in this diff.

@rolandwalker rolandwalker force-pushed the RW/complete-filenames-all-special-commands branch 2 times, most recently from f191ee3 to 7a5430d Compare February 28, 2026 13:04
Although filename completion has a number of limitations currently, we
should still offer it on each special command which accepts a filename,
not just "source".
@rolandwalker rolandwalker force-pushed the RW/complete-filenames-all-special-commands branch from 7a5430d to 1c31b83 Compare February 28, 2026 22:52
@rolandwalker rolandwalker merged commit 64e3cbc into main Feb 28, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/complete-filenames-all-special-commands branch February 28, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants