Inconsistant argument with method === 'letters'#58
Open
QuentinRoy wants to merge 1 commit intodavatron5000:masterfrom
QuentinRoy:letter-args
Open
Inconsistant argument with method === 'letters'#58QuentinRoy wants to merge 1 commit intodavatron5000:masterfrom QuentinRoy:letter-args
QuentinRoy wants to merge 1 commit intodavatron5000:masterfrom
QuentinRoy:letter-args
Conversation
…rgument to the init method which is inconsistant with the other call. Rename the init method to 'letters' and call it with no argument if the method parameter is not provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When called with 'letters' as arguments, 'letters' is passed as an argument to the init method.
Even if arguments are ignored anyway, it bothered me a little bit.