Skip to content

fix(api): Widen BGPRouter nodeID to the full 16-bit uSID field #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Sep 21, 2026
Merged

fix(api): Widen BGPRouter nodeID to the full 16-bit uSID field #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api/v1alpha1/router_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ type BGPRouterSpec struct {
// +optional
SRv6Locator string `json:"srv6Locator,omitempty"`

// NodeID is this router's 8-bit slot within its PoP's SRv6Locator block,
// NodeID is this router's 16-bit slot within its PoP's SRv6Locator block,
// used for RFC 9800 NEXT-CSID compression. Unique within the PoP.
// Values 0 and 255 are reserved.
// The uSID carrier format reserves 0x0000 and 0xE000-0xFFFF (the latter is
// Function space, not Node-ID space), leaving 0x0001-0xDFFF assignable.
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Maximum=254
// +kubebuilder:validation:Maximum=57343
// +optional
NodeID int32 `json:"nodeID,omitempty"`

Expand Down
7 changes: 4 additions & 3 deletions config/crd/network.datumapis.com_bgprouters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,12 @@ spec:
type: integer
nodeID:
description: |-
NodeID is this router's 8-bit slot within its PoP's SRv6Locator block,
NodeID is this router's 16-bit slot within its PoP's SRv6Locator block,
used for RFC 9800 NEXT-CSID compression. Unique within the PoP.
Values 0 and 255 are reserved.
The uSID carrier format reserves 0x0000 and 0xE000-0xFFFF (the latter is
Function space, not Node-ID space), leaving 0x0001-0xDFFF assignable.
format: int32
maximum: 254
maximum: 57343
minimum: 1
type: integer
routerID:
Expand Down
2 changes: 1 addition & 1 deletion docs/api/bgp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ _Appears in:_
| `routerID` _string_ | RouterID is a unique 32-bit identifier expressed in IPv4 dotted-decimal notation.<br />In an IPv6-only underlay this is a logical identifier only. | | Format: ipv4 <br />Required: \{\} <br /> |
| `addressFamilies` _[AddressFamily](#addressfamily) array_ | AddressFamilies defines the address families this router activates. | | MinItems: 1 <br /> |
| `srv6Locator` _string_ | SRv6Locator is the SRv6 locator block this router owns, expressed as an<br />IPv6 CIDR (e.g. "2001:db8:ff01::/48"). Individual SRv6 endpoint SIDs are<br />host addresses within this block. | | |
| `nodeID` _integer_ | NodeID is this router's 8-bit slot within its PoP's SRv6Locator block,<br />used for RFC 9800 NEXT-CSID compression. Unique within the PoP.<br />Values 0 and 255 are reserved. | | Maximum: 254 <br />Minimum: 1 <br /> |
| `nodeID` _integer_ | NodeID is this router's 16-bit slot within its PoP's SRv6Locator block,<br />used for RFC 9800 NEXT-CSID compression. Unique within the PoP.<br />The uSID carrier format reserves 0x0000 and 0xE000-0xFFFF (the latter is<br />Function space, not Node-ID space), leaving 0x0001-0xDFFF assignable. | | Maximum: 57343 <br />Minimum: 1 <br /> |
| `listenPort` _integer_ | ListenPort is the TCP port this router listens on for incoming BGP<br />peer connections. Defaults to 179 (the IANA-assigned BGP port) if unset. | | Maximum: 65535 <br />Minimum: 1 <br /> |


Expand Down
Loading