feat: add replica retention rules to karmada - #202
Open
savme wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Karmada retention for
WorkloadDeployment.spec.replicas.Why
WorkloadDeploymentnow exposes/scale, backed byspec.replicas. HPA will write that field in the member cluster. Without retention, Karmada resyncs would overwrite the member cluster's localspec.replicasvalue with the hub copy, undoing local scale decisions.Details
retentioninterpreter to the existingWorkloadDeploymentResourceInterpreterCustomization.spec.replicasfrom the observed member-cluster object.make interpreter-testusingkarmadactl interpret.make test.Test
Related to #201
Related to datum-cloud/enhancements#799