ci(macos): fix dSYM/Sentry paths when Dioxus output dir differs#157
Merged
Conversation
Dioxus may emit release/macos/*.app under target/dx with a non-Datum segment. Prefer ui/dist/Datum.app after DMG prep, fall back to find, and read CFBundleExecutable for dsymutil. Align Sentry upload with the same layout. Harden DMG copy in workflows and build-dmg.sh. Co-authored-by: Cursor <cursoragent@cursor.com>
… matrix) - Download prebuilt `dx` binary from Dioxus releases instead of building dioxus-cli from source. Saves ~5–10 min per matrix leg. - Pin Swatinem/rust-cache to a stable shared-key per OS so the in-place version bump + `cargo generate-lockfile` no longer evict the dep cache every run. Skip saving the cache on PRs to avoid pollution. - Limit PR matrix in bundle.yml to ubuntu-latest as a smoke check; full three-OS matrix still runs on main, tag pushes, and manual dispatch. - Add a `paths` filter so PRs that don't touch Cargo/UI/lib/cli skip the bundle entirely. - In ci.yml run cargo test/clippy/fmt only on Linux; cargo check still runs on all three OSes to catch platform-specific compile errors. Co-authored-by: Cursor <cursoragent@cursor.com>
windows-latest currently aliases to the windows-2025 image, which ships Visual Studio 2026 preview (VS18 / MSVC 14.50). cmake-rs (used by aws-lc-sys, pulled in transitively via rustls -> aws-lc-rs) can't resolve a generator for VS18, and MSVC 14.50's vcruntime_c11_stdatomic.h demands /std:c11 which the aws-lc-sys build script doesn't pass. The result is a deterministic failure at `dx bundle` on windows-latest. Pin all three workflows to windows-2022 (VS17) until the toolchain catches up. Co-authored-by: Cursor <cursoragent@cursor.com>
kevwilliams
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tag builds failed at Generate dSYM (macOS) because the workflow assumed a fixed path (
target/dx/Datum/release/macos/Datum.appand executableDatum). Newer Dioxus layouts may use a different segment undertarget/dx.Changes
ui/dist/Datum.app(after DMG prep), fall back tofindundertarget/dx/*/release/macos/*.app, and resolve the binary viaCFBundleExecutableinInfo.plist.Contents/MacOSdirectory (dist first, then fallback).bundle.yml,manual-release.yml,build-dmg.sh): If the legacyDatumpath is missing, copy the first matching.appfromrelease/macos.Testing
CI: push a tag or run the bundle workflow on this branch as appropriate.
Made with Cursor