perf: reduce memory usage with lazy schema loading and tab eviction#132
Merged
perf: reduce memory usage with lazy schema loading and tab eviction#132
Conversation
- Replace bulk fetchAllColumns() with lazy per-table fetch and LRU cache (max 50 tables)
- Evict inactive tab data more aggressively (keep at most 2 loaded)
- Defer Phase 2 background work by 200ms to reduce peak memory overlap
- Share schema provider with sidebar to eliminate redundant DB queries
- Release QueryResult earlier via scoped do{} block before await suspension
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchAllColumns()with lazy per-table column fetch and LRU cache (max 50 tables) inSQLSchemaProvider— avoids loading all column metadata upfront for large databasesQueryResultcan be deallocated first, reducing peak memory overlapSQLSchemaProviderwithSidebarViewModelso sidebar reads cached tables instead of issuing a redundantfetchTables()queryQueryResultearlier inexecuteQueryInternalby wrapping extraction in ado {}block before theawait MainActor.runsuspension pointTest plan
SQLSchemaProviderTests)TabEvictionTests)LiveTableFetcherTests)