Replace Timbre with Telemere and set up SLF4J bridge#51
Open
Replace Timbre with Telemere and set up SLF4J bridge#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the existing
timbre-based logging withtelemere.The following changes were made:
timbrewithtelemerein thedeps.ednfileinfo,warn, anderrormacros insrc/dvb/server/log.cljto work withtelemeretelemere's built inhandler:filetelemere-slf4jand updatedslf4j-apito 2.0.13 to routeslf4jlogs totelemere, which doesn't haveslf4jsupport by default.Reason for change:
This change addresses part of an open item in the projects board.
Testing:
Comparison of startup log output with previous and new system:
Previous logs:
New logs:
Ran existing test suite, all tests passed:
Note
I left some configuration options for
telemere.handler:filecommented out insrc/dvb/server/system/log.clj. These change log rotation, compression, formatting, etc. These are optional, can be removed if not needed.