Some changes, additions#6
Some changes, additions#6Aransentin wants to merge 2 commits intodatenwolf:masterfrom Aransentin:master
Conversation
|
Wow, that's quite some work. However you'll have to add the memcpy stuff again, because by removing it you broke "in-place" operations. Think like are broken now. It's most easy to see for transpose, which is essentially a swap across the diagonal. When writing a swap you must do By removing the memcpy, e.g. in transpose you're clobbering the values you're later going to need in that loop. In invert, Laplace expansion is nice. I did that determinant thing, by having it written out by some code generator (actually I was mostly interested in what a compiler's optimizer would make out of it). However I might replace it with a decomposition based method; using a eigendecomposition based method would give you eigenvalue/eigenvectors code, which again can be used for quaternion from rotation matrix calculations. |
|
You are correct about the temporary memory buffers, of course... I re-added them.
|
|
Looks like @Aransentin's first commit was merged but not the second, so the temporary buffers are currently missing in master and in-place operations are broken. |
|
just poking at this, because nearly 2 years later in-place operations are still broken :( |
|
Do we really need |
Hi there! I made some changes to your library:
Functionality:
Style: