Compaction pr updates#680
Open
jshook wants to merge 2 commits into
Open
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch PR makes two key changes:
jvector.physical_core_count.Given the thread resource changes here, this is likely impacting in a couple key areas:
These previously run tests also indicated robust recall results across several scenarios including different datasets and sizes up to 10M, so recall was effectively unchanged compared to previous results with this compaction branch. What did change was the operational envelope (as described above)
Nonetheless, given that this is a relatively non-trivial adjustment to the operational profile near a release, we need to have sufficient testing on it.
I feel very strongly that we should not merge the upstream compaction-pr without this pr merged into it first, as the system saturation which would occur with the current thread pool configuration would certainly impact front-end operations.