Rename-DbaDatabase - Build expected file paths without validating drives of the test client - #10606
Open
andreasjordan wants to merge 1 commit into
Open
Rename-DbaDatabase - Build expected file paths without validating drives of the test client#10606andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
…ves of the test client (do Rename-DbaDatabase) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The physical-name template test builds its expected paths with
Join-Pathfrom the file paths of the instance. Windows PowerShell validates the drive qualifier ofJoin-Pathagainst the drives of the machine running the test, so against a remote instance whose files live on a drive the test client does not have - such as a failover cluster instance keeping its databases on a clustered disk - the test fails with "Cannot find drive. A drive with the name 'S' does not exist" although the command works.Changes (tests only)
The four expected paths are now built with
[System.IO.Path]::Combine, which composes strings without touching the provider - and is also what Rename-DbaDatabase itself builds the new path with, so the expectation mirrors the command exactly.Verified against a clustered instance with databases on a clustered drive (the previously failing shape) and against a regular instance, both warning-free with all tests passing.
created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code