Skip to content

Use executing binary path for install command#472

Merged
nblumhardt merged 1 commit into
datalust:devfrom
KodrAus:fix/windows-forwarder-install
Jun 12, 2026
Merged

Use executing binary path for install command#472
nblumhardt merged 1 commit into
datalust:devfrom
KodrAus:fix/windows-forwarder-install

Conversation

@KodrAus

@KodrAus KodrAus commented Jun 12, 2026

Copy link
Copy Markdown
Member

Closes #432

When installed as a dotnet tool, we distribute a platform-independent nupkg and the local dotnet toolchain assembles a shim binary over it. The DLL path in this case doesn't point anywhere near where the actual binary is.

I've tweaked it to use Environment.ProcessPath, which in my local testing here in Windows does point in the right direction. It'll need a check with the actual nupkg too.

@nblumhardt nblumhardt merged commit 3977570 into datalust:dev Jun 12, 2026
2 checks passed
@nblumhardt

Copy link
Copy Markdown
Member

mcp install assumes that seqcli is a binary on $PATH; it might not be a bad idea to switch strategies to the one above there, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

forwarder install points to missing executable file when seqcli is running as a dotnet tool

2 participants