Improve time trigger Python API [ch63893] #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #63893: bug in public API for scenario triggers add_monthly_trigger & add_periodic_trigger. |
pbailly
commented
Apr 29, 2021
| self.raw_triggers.append(trigger) | ||
|
|
||
| def add_daily_trigger(self, hour=2, minute=0, days=None): | ||
| def add_daily_trigger(self, hour=2, minute=0, days=None, year=None, month=None, day=None, repeat_every=1, timezone="SERVER"): |
Contributor
Author
There was a problem hiding this comment.
I hate this paramter ordering, but we have to keep the legacy working...
If you have a better ordering that is consistent between the 4 methods, I would gladly get it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch63893]
Time Triggers have new capabilities, let's add them to the python API.
Associated PR: https://github.com/dataiku/dip/pull/12548