feat: matomo site search tracking - #1247
Open
nicolaskempf57 wants to merge 6 commits into
Open
nicolaskempf57 wants to merge 6 commits into
nicolaskempf57 wants to merge 6 commits into
Conversation
added 5 commits
September 22, 2026 12:05
… on search routes
ThibaudDauce
approved these changes
Sep 24, 2026
Comment on lines
+27
to
+33
| const { $matomo } = useNuxtApp() | ||
|
|
||
| function trackSearch(keyword: string, type: string, total: number) { | ||
| if (!import.meta.client) return | ||
| $matomo.trackSiteSearch(keyword, type, total) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Why use an event from GlobalSearch, I would prefer to have this in GlobalSearch.vue directly. I think it's to avoid having Matomo inside the datagouv-components but we could add an optional Matomo object inside the datagouv-components and do the tracking there? It would prevent the duplicate listeners in organisation and datasets and also I think @search event reads a little bit like the parent of this component should do something about the search?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.