fix: show expected domain name meteo.data.gouv.fr - #1246
Merged
Merged
Conversation
I guess it's better to show the real domain name: meteo.data.gouv.fr. Currently, the text shown is météo.data.gouv.fr is a theoritically valid domain name, but it does not point to the portal, so it's slightly misleading. An alternative infra-wise would be to create the subdomain météo.data.gouv.fr and to serve the website there (or redirect to meteo).
Contributor
Author
|
^ erreur sur la CI : quelques pixels différent sur la page d'accueil, ce qui est normal puisque le texte a légèrement changé. Il faut que je comprenne comment mettre à jour l'image de référence |
Contributor
si tu es sur linux, tu peux les mettre à jour avec : |
nicolaskempf57
self-requested a review
September 24, 2026 07:26
chore: update screenshots
Snapshots produced inside mcr.microsoft.com/playwright:v1.63.0-noble with CI's env vars, so they match what CI renders.
chore(e2e): regenerate homepage screenshots in CI container
Move data-testid=udata-version and data-testid=commit-version to the parent <li> elements and mask those in full-page screenshots: the li is full column width, so the mask rectangle is constant whatever the version string or commit id length is. Verified by regenerating in the CI container against udata@main, then re-running with a different udata version (17.81.dev7) — snapshots still match. Regenerated homepage and edito snapshots in mcr.microsoft.com/playwright:v1.63.0-noble with CI's env vars.
chore(e2e): stabilize footer version masks in snapshots
… in CI Reverted in a follow-up commit once the regenerated screenshots are applied.
The CI run with the flag regenerated snapshots byte-identical to the ones already committed (md5-verified), confirming they match CI's rendering. Verification must now compare against them for real.
GitHub runners vary in CPU generation, and Chromium's Skia text anti-aliasing differs subtly between SIMD code paths: two CI runs of the same commit produce ~0.1% differing pixels on text rows and chart labels (measured: 8157 px on 7.2M, worst case). The edito spec already tolerates maxDiffPixelRatio 0.01 for the same reason; apply it to the homepage spec too.
test: add `maxDiffPixelRatio` for homepage too
nicolaskempf57
approved these changes
Sep 25, 2026
Contributor
Author
|
merci ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess it's better to show the real domain name: meteo.data.gouv.fr.
Currently, the text shown is météo.data.gouv.fr. It is a theoretically valid domain name, but it does not point to the portal, so it's slightly misleading. An alternative infra-wise would be to create the subdomain météo.data.gouv.fr and to serve the website there (or redirect to meteo).