Use Electron system directory picker - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dialog.showOpenDialogWhy
Packaged Windows builds could report
win32 folder dialog worker exited before reporting a result. The Electron main process already owns the native window, so it should own the system directory dialog as well.User impact
Windows and macOS now use their normal system folder picker without the crash-prone worker process.
Validation
npm run typechecknpm test(71 tests)npm run buildnpm run package:dev:dirnpm ci --ignore-scriptsfollowed bynpm run postinstall