Skip to content

chore: Migrate gsutil usage to gcloud storage#6057

Open
bhandarivijay-png wants to merge 2 commits intodatacommonsorg:masterfrom
bhandarivijay-png:ai-gsutil-migration-c6fe36e33ac7436dbec5df4a2fb7db7b
Open

chore: Migrate gsutil usage to gcloud storage#6057
bhandarivijay-png wants to merge 2 commits intodatacommonsorg:masterfrom
bhandarivijay-png:ai-gsutil-migration-c6fe36e33ac7436dbec5df4a2fb7db7b

Conversation

@bhandarivijay-png
Copy link
Copy Markdown

Automated: Migrate {target_path} from gsutil to gcloud storage

This CL is part of the on going effort to migrate from the legacy gsutil tool to the new and improved gcloud storage command-line interface.
gcloud storage is the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with other gcloud components. 🚀

Automation Details

This change was generated automatically by an agent that targets users of gsutil.
The transformations applied are based on the gsutil to gcloud storage migration guide.

⚠️ Action Required: Please Review and Test Carefully

While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between gsutil and gcloud storage that could impact your workflows.
For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the gcloud storage rsync command has a different file deletion logic than gsutil rsync, which could lead to unintended file deletions.

Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.

Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.

Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.

Support and Collaboration

The GCS CLI team is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.
We are happy to work with you to test and adjust these changes as needed.

Contact: gcs-cli-hyd@google.com

We appreciate your partnership in this important migration effort!

#gsutil-migration

@bhandarivijay-png
Copy link
Copy Markdown
Author

Hi @juliawu, Can we get your review on this PR? Thanks!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's interaction with Google Cloud Storage by replacing all occurrences of the legacy gsutil command-line tool with the recommended gcloud storage CLI. This change aims to leverage the improved performance, unified authentication, and consistent command structure offered by gcloud storage. The migration was performed automatically and requires careful validation to ensure all Cloud Storage operations continue to function as expected.

Highlights

  • Migration to gcloud storage: All instances of gsutil commands have been systematically migrated to their gcloud storage equivalents across various scripts and Dockerfiles.
  • Automated Change: This migration was automatically generated as part of an ongoing effort to standardize interactions with Google Cloud Storage using the modern gcloud storage tool.
  • Call for Thorough Testing: Reviewers are urged to thoroughly test these changes in appropriate environments due to potential subtle differences in command behavior and output between gsutil and gcloud storage.
Changelog
  • build/cdc_data/Dockerfile
    • Updated model copying command from gsutil to gcloud storage cp --recursive.
  • build/cdc_services/Dockerfile
    • Updated model and embeddings copying commands from gsutil to gcloud storage cp --recursive.
  • build/website_cron_testing/run_website_cron_tests.sh
    • Replaced gsutil cp with gcloud storage cp for uploading nodejs query outputs.
    • Replaced gsutil cp with gcloud storage cp for uploading sanity test results.
    • Replaced gsutil cp with gcloud storage cp for downloading adversarial test inputs and uploading reports.
  • deploy/terraform-datacommons-website/README.md
    • Updated bucket creation command from gsutil mb to gcloud storage buckets create.
  • deploy/terraform-datacommons-website/modules/esp/main.tf
    • Updated a commented gsutil cp example to gcloud storage cp.
  • gke/setup_esp.sh
    • Replaced gsutil cp with gcloud storage cp for downloading mixer-grpc protobuf.
  • model_server/push_image.sh
    • Updated model copying command from gsutil cp -r to gcloud storage cp --recursive.
  • run_sdg_sanity.sh
    • Replaced gsutil cp with gcloud storage cp for uploading SDG sanity test results.
  • run_website_adversarial.sh
    • Replaced gsutil cp with gcloud storage cp for copying adversarial test input files.
    • Replaced gsutil cp with gcloud storage cp for uploading adversarial test reports.
  • run_website_sanity.sh
    • Replaced gsutil cp with gcloud storage cp for uploading website sanity test results.
  • scripts/deploy_cloud_esp.sh
    • Replaced gsutil cp with gcloud storage cp for downloading mixer-grpc protobuf.
  • scripts/deploy_gke_helm.sh
    • Replaced gsutil cp with gcloud storage cp for downloading mixer-grpc protobuf.
  • scripts/deploy_latest.sh
    • Replaced gsutil cp with gcloud storage cp for bigquery version file.
    • Replaced gsutil ls with gcloud storage ls and gsutil cat with gcloud storage cat for cache version files.
  • scripts/install_custom_dc.sh
    • Updated gsutil ls and gsutil mb commands to gcloud storage ls --buckets and gcloud storage buckets create for Terraform state bucket management.
    • Replaced gsutil cp with gcloud storage cp for mixer-grpc protobuf.
  • scripts/update_gcs_feature_flags.sh
    • Replaced gsutil cp with gcloud storage cp for fetching and uploading feature flags.
  • server/routes/redirects/README.md
    • Updated an example gsutil cp command to gcloud storage cp.
  • tools/delete_cron_outputs/run.sh
    • Replaced gsutil ls with gcloud storage ls for listing folders.
    • Replaced gsutil -m rm -r with gcloud storage rm --recursive for deleting outdated folders.
Activity
  • The pull request was automatically generated by an agent as part of an ongoing effort to migrate from the legacy gsutil tool to gcloud storage.
  • The author explicitly requested thorough testing of these changes in appropriate environments before merging, emphasizing potential differences in command output and behavior (e.g., gcloud storage rsync's file deletion logic differs from gsutil rsync).
  • The GCS CLI team offered support and collaboration for any encountered issues, complex use cases, or assistance with testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains automated changes to migrate from gsutil to gcloud storage commands across various shell scripts, Dockerfiles, and documentation. The replacements of commands like cp, ls, mb, and rm with their gcloud storage equivalents, including flag conversions like -R to --recursive, appear to be correct and consistently applied. After a thorough review of all changes, I have not identified any issues or required modifications.

Copy link
Copy Markdown
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Risha, I took a look at all the changes. Given where all the scripts are run from, we do already pre install gcloud in the base images.

I believe this should be a safe change. Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants