Implement Chart Style Options Menu#378
Open
PauloMFJ wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the card component architecture by shifting the responsibility of rendering actions, content, and footers from the shape utility down to the specific card variants (Card.Text and Card.Chart). It also introduces a new MenuChartOptions component to support switching chart styles. The review feedback highlights a few issues: a missing ref attachment on the dialog container which breaks the focus trap, a missing auto-close behavior when confirming a chart style, and a regression where an undefined card variant no longer falls back to rendering text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds the chart-style options menu to chart cards, reachable from the card's action bar.
What's new
Refactor
Screenshot