Skip to content

Implement Prompt Tags Support#374

Open
PauloMFJ wants to merge 10 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/prompt-tags
Open

Implement Prompt Tags Support#374
PauloMFJ wants to merge 10 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/prompt-tags

Conversation

@PauloMFJ

Copy link
Copy Markdown
Contributor

Overview

Implement initial prompt tags support.

image

@PauloMFJ PauloMFJ self-assigned this Jun 22, 2026
@PauloMFJ PauloMFJ marked this pull request as draft June 22, 2026 20:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the design token system to support color aliases, RGB/RGBA value forms, and component-scoped sets, updating components like Button to use semantic variant and tone props instead of custom color schemes. It also introduces a new Tag component integrated into the Prompt and QueryProvider to support query tags. Feedback highlights a potential duplicate key issue when adding tags in QueryProvider, a state-reading and validation concern in PageHome's submit handler, and a missing background color for the backdrop-filter in the Tag container styles.

Comment thread dataweaver/apps/web/src/components/scopes/atlas/query_provider.tsx
Comment thread dataweaver/apps/web/src/components/scopes/page_home/page_home.tsx
Comment thread dataweaver/apps/web/src/components/elements/tag.module.scss Outdated
@PauloMFJ PauloMFJ marked this pull request as ready for review June 23, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant