Tuberculosis: Estimated incidence rate per 100 000 population#1945
Open
smarthg-gi wants to merge 2 commits intodatacommonsorg:masterfrom
Open
Tuberculosis: Estimated incidence rate per 100 000 population#1945smarthg-gi wants to merge 2 commits intodatacommonsorg:masterfrom
smarthg-gi wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new data import for WHO Tuberculosis Estimated Incidence Rate statistics, including a Python script for data retrieval, manifest configurations, and mapping files. Several critical and moderate issues were identified during the review: the manifest.json contains invalid JSON due to a literal newline character, the data download script lacks a timeout for network requests and uses a filename inconsistent with the rest of the configuration, and the TMCF incorrectly applies the scalingFactor property to StatVarObservation nodes. Additionally, it is recommended to implement explicit checks for missing ISO3 codes after merging datasets to improve data robustness.
statvar_imports/who/tuberculosis_estimated_incidence_rate/manifest.json
Outdated
Show resolved
Hide resolved
statvar_imports/who/tuberculosis_estimated_incidence_rate/tb_data_download.py
Show resolved
Hide resolved
statvar_imports/who/tuberculosis_estimated_incidence_rate/tb_data_download.py
Show resolved
Hide resolved
statvar_imports/who/tuberculosis_estimated_incidence_rate/tb_data_download.py
Show resolved
Hide resolved
...culosis_estimated_incidence_rate/test_data/tuberculosis_estimated_incidence_rate_output.tmcf
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated number of new and recurrent tuberculosis (TB) cases arising in a given year expressed as a rate per 100 000 population. All forms of TB are included, including cases in people living with HIV and those with drug-resistant TB.
PR_CHECKLIST=Link