CensusACS5YearSurvey_SubjectTables_S0701 config#1944
Open
saanikaaa wants to merge 2 commits intodatacommonsorg:masterfrom
Open
CensusACS5YearSurvey_SubjectTables_S0701 config#1944saanikaaa wants to merge 2 commits intodatacommonsorg:masterfrom
saanikaaa wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ACS 5-year subject table S0701 specification to include data for the years 2020 through 2024. The changes involve adding new columns to the ignore list, defining extensive denominator mappings for inflation-adjusted individual income, and updating the token ignore list. Feedback highlights a critical issue where adding inflation-adjusted income strings to the ignore tokens list conflicts with explicit mappings, which would cause the importer to fail. Additionally, a minor formatting inconsistency regarding comma placement was identified for correction.
Contributor
|
Resolve Gemini comments |
Contributor
|
Add PR checklist |
saanikaaa
changed the title
Contributor
Author
Done |
Contributor
Author
Done |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_CHECKLIST = Link