changed the output csv format to get all data#1941
Open
niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
Open
changed the output csv format to get all data#1941niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Eurostat life expectancy data processing pipeline by updating the preprocess.py script and simplifying the associated TMCF file. The script has been rewritten to transform input data into a long-format CSV, dynamically generating StatVar DCIDs from age and sex dimensions and mapping geographic codes to standardized DCIDs. Consequently, the TMCF has been reduced to a single template node to accommodate this new data structure. I have no feedback to provide.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes -
Switched to a more robust groupby and concat method that uses an Outer Join.
The processing logic now supports "sparse data," meaning it can handle the incomplete 2024 entries without triggering row deletions.
Each Statistical Variable is now processed as a subset and joined horizontally, ensuring that a lack of data in one category does not affect the data availability of another.
Tmcf changes- As the output format is changing tmcf is changed for all rows