Support GCS paths for server and tool instructions#183
Merged
keyurva merged 3 commits intodatacommonsorg:mainfrom Apr 3, 2026
Merged
Support GCS paths for server and tool instructions#183keyurva merged 3 commits intodatacommonsorg:mainfrom
keyurva merged 3 commits intodatacommonsorg:mainfrom
Conversation
keyurva
had a problem deploying
to
evals-and-secrets
GitHub Actions
Error
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for reading external content from Google Cloud Storage (GCS) in addition to local file paths. Key changes include the implementation of GCS-specific utility functions for path parsing and content retrieval, the addition of the google-cloud-storage dependency, and new unit tests to verify GCS integration. Feedback was provided regarding the GCS path parsing logic, specifically to handle potential double slashes from trailing slashes in the base path and to ensure the bucket name is not empty.
keyurva
had a problem deploying
to
evals-and-secrets
GitHub Actions
Error
keyurva
had a problem deploying
to
evals-and-secrets
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gs://paths for server and tool instructions..env.sampleto document GCS support forDC_INSTRUCTIONS_DIR.