fix(ai): align conversation execution and query tool contracts - #782
fix(ai): align conversation execution and query tool contracts#782izadoesdev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Conversational requests such as “Thanks, what is our retention?” could lose every tool through keyword filtering. MCP data calls also repeatedly supplied a preset and explicit dates together, while dashboard Balanced reasoning sent Anthropic options to the configured OpenAI model.
Use one native ToolLoopAgent setup for dashboard and shared MCP/Slack execution, derive provider options from the selected model, attribute billing to the actual model, and expose the existing analytics discovery/schema tools without keyword gating. Make optional internal MCP data inputs nullable on the wire and normalize them with Zod before the unchanged query planner. Keep strict generation; disabling it alone did not fix the observed failures. The dashboard default reasoning label now reflects provider defaults. Production/config code is reduced by 203 lines.
Validation:
Review limits: broader tool exposure increases context cost; retention discovery remains unreliable. Dashboard billing-provider errors now fail the request, matching MCP, instead of allowing execution. No database-schema, history, delivery or investigation-loop migration; no dependency on #751. Kept as a draft for review; no deployment or merge performed. AI-assisted, maintainer-directed implementation with independent read-only review.
Summary by cubic
Aligns conversation execution and query tool contracts so casual requests like “what is our retention?” keep all tools, provider options match the selected model, and MCP data inputs accept the same wire format across clients.
Changes
ToolLoopAgentsetup for dashboard, MCP, and Slack.Side effects
Written for commit f612504. Summary will update on new commits.