fix(dashboard): match business context to organization settings - #763
Conversation
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR aligns Business Context with the established Organization Settings presentation and interaction model.
Confidence Score: 5/5The PR appears safe to merge with no concrete correctness, security, or repository-rule issues identified. The duplicate keyboard listeners created by shared desktop and mobile top-bar rendering are safely serialized by the synchronous guard, source URLs are validated before rendering, and the revised layout follows the existing General settings structure. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Edit business brief] --> B[Draft becomes dirty]
B --> C[Top-bar Save and Discard appear]
C -->|Discard| D[Restore saved brief]
C -->|Click Save or keyboard shortcut| E{Save already active?}
E -->|Yes| F[Ignore duplicate submission]
E -->|No| G[Set synchronous saving guard]
G --> H[Submit existing save mutation]
H -->|Success| I[Clear draft and show saved notice]
H -->|Failure| J[Keep edits and show error]
I --> K[Release saving guard]
J --> K
Reviews (1): Last reviewed commit: "fix(dashboard): match business context t..." | Re-trigger Greptile |
Business Context looked disconnected from Organization Settings: it used a wider unframed layout, an oversized text area, bottom-of-page save controls, and inline source links that were difficult to scan.
Use the same shared cards, column width, spacing, typography, and scrolling layout as General settings. Bound the editor to 12 rows, move Save/Discard to the standard top bar, make mobile labels compact, and display sources as individual rows with page titles and URLs. Loading states use the matching card layout. A synchronous save guard prevents duplicate submissions from the shared desktop/mobile shortcut controls.
Validation: root lint, all 33 type-check tasks, and six authenticated browser regressions including a real keyboard save that submits once. Compared against the actual General settings page, checked light/dark themes and 390px mobile, and preserved the saved local preview brief.
Scope: presentation of the existing business context feature. No API, storage, model, or dependency changes. Based on current staging after #762; no dependency on #751. AI-assisted implementation and visual review.
Summary by cubic
Aligns the business context editor with the Organization Settings design so it uses the same card layout, column width, and top-bar Save/Discard controls as General settings. This is a presentation-only change; no API, storage, model, or dependency behavior changes.
Details
Written for commit 8e0e82d. Summary will update on new commits.