Feature Filter dashboard widgets using date select#308
Open
namanvats wants to merge 1 commit intodatabrickslabs:mainfrom
Open
Feature Filter dashboard widgets using date select#308namanvats wants to merge 1 commit intodatabrickslabs:mainfrom
namanvats wants to merge 1 commit intodatabrickslabs:mainfrom
Conversation
Author
|
Please review @JCZuurmond |
JCZuurmond
reviewed
Oct 23, 2024
Contributor
JCZuurmond
left a comment
JCZuurmond
left a comment
There was a problem hiding this comment.
Code changes look good, but missing an integration test to show the date picker works. Please attach a screenshot of the created dashboard
Contributor
|
@namanvats : Could you give a status update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one adds Filter dashboard widgets using date select as requested here : #170