Skip to content

[AIGTWY-4759] Add fixture-driven managed-config integration tests - #703

Closed
david-siqi-liu wants to merge 2 commits into
david/aigtwy-4759-managed-diagnosticsfrom
david/aigtwy-4759-managed-fixture-tests
Closed

david-siqi-liu wants to merge 2 commits into
david/aigtwy-4759-managed-diagnosticsfrom
david/aigtwy-4759-managed-fixture-tests

Conversation

@david-siqi-liu

Copy link
Copy Markdown
Collaborator

Stacked on #699 (parent). Adds a managed_fixture integration layer that injects the admin CodingAgentConfig via the built-in UCODE_MANAGED_CONFIG_STUB hook, so the real ug and agent CLIs are exercised across managed-config shapes the live ca-central workspace does not publish. Auth, normalization, config writers, and the agent binaries stay real; the fetch/wire contract stays covered by the un-stubbed managed tests.

Seed batch (CUJ table to follow as it expands):

  • enabled_agents is an allowlist (single-agent config configures only that agent)
  • tracing on/off writes/omits the OTLP telemetry env
  • default_agent-not-in-enabled_agents is rejected with a validation error

Policy: sanctioned the input-only stub in tests/AGENTS.md and tests/CLAUDE.md; runs in the existing managed lanes via a (managed or managed_fixture) marker filter.

This pull request and its description were written by Isaac.

The managed lanes 403'd because the managed workspace IP-blocked GitHub runners; that is fixed
config-side (the E2E_ADMIN_* secrets repointed to runner-reachable ca-central plus a published
CodingAgentConfig). This makes the lanes work and widens their coverage:

- Install both agent CLIs in each managed lane, since a managed config enables both agents and
  `ug configure` applies it to every enabled agent (each lane previously installed only its own
  agent and failed configuring the other).
- Add a managed idempotency CUJ: two `ug configure` runs apply the admin config to both enabled
  agents identically, which also guards the all-enabled-agents apply. Deterministic config-file
  assertions, no extra TUI.
- Keep the lanes non-blocking until this path is proven stable on ca-central.

Co-authored-by: Isaac <no-reply@databricks.com>
@david-siqi-liu
david-siqi-liu force-pushed the david/aigtwy-4759-managed-fixture-tests branch from 032d5e4 to af3abe6 Compare September 17, 2026 02:49
Introduce a `managed_fixture` layer that injects the admin CodingAgentConfig via the built-in
UCODE_MANAGED_CONFIG_STUB hook, so the real ug and agent CLIs are exercised across managed-config
shapes the live workspace does not publish. Auth, normalization, config writers, and the binaries
stay real; the fetch/wire contract stays covered by the un-stubbed `managed` tests.

- Seed CUJs: enabled_agents allowlist, tracing on/off OTEL env, default_agent validation.
- Run in the existing managed lanes via a `(managed or managed_fixture)` marker filter.
- Sanction the input-only stub in tests/AGENTS.md and tests/CLAUDE.md.

Co-authored-by: Isaac <no-reply@databricks.com>
@david-siqi-liu
david-siqi-liu force-pushed the david/aigtwy-4759-managed-fixture-tests branch from af3abe6 to 5c9ca2c Compare September 17, 2026 02:57
@david-siqi-liu
david-siqi-liu force-pushed the david/aigtwy-4759-managed-diagnostics branch from de07883 to 8a9ee0d Compare September 17, 2026 03:11
@david-siqi-liu

Copy link
Copy Markdown
Collaborator Author

Rolled into #699 as a single combined PR (both-agents fix + managed tests + the managed_fixture layer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant