Conversation
lilly-luo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
1/ user triggered isaac / isaac codex and started the oauth flow. this locks the oauth file so we don't have multiple retries (the browser storm from earlier)
2/ oauth flow did not complete, either because user didn't login or because something went wrong. because the oauth flow never completed, the lock from (1) persists
3/ future isaac / isaac codex issues cannot complete because of the lock
after:
1/ user triggered isaac / isaac codex and started the oauth flow. this locks the oauth file so we don't have multiple retries (the browser storm from earlier)
2/ oauth flow did not complete, either because user didn't login or because something went wrong. after 180s, the lock is released
3/ future isaac / isaac codex sessions try for up to 185s to re-acquire the lock.