Conversation
The relayed-Claude and Codex-through-OpenAI-MPS launches are exercised end-to-end by the black-box integration suite (test_ug_claude_relayed and test_ug_configure_codex_openai_mps), which drive the real installed CLI against the same CI MPSes. The in-process e2e duplicates add no coverage, and each CI run burns the personal Anthropic subscription token and the OpenAI-key MPS a second time. - Remove TestModelProviderLaunch.test_launch_claude_through_relayed_provider and test_launch_codex_through_provider, plus the now-unused _first_relayed_service helper, CI_OPENAI_MPS / CI_OPENAI_MODEL constants, and the threading import. - Stop wiring CLAUDE_CODE_OAUTH_TOKEN into the e2e-shards job (no e2e test uses it anymore) and simplify the codex shard keyword. Merge after #565, which adds the integration relayed test; until then the relayed CUJ has no in-suite coverage on main. Co-authored-by: Isaac <no-reply@databricks.com>
masonc08
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
September 16, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes two in-process tests in
tests/test_e2e.pythat duplicate coverage already provided by the black-box integration suite:TestModelProviderLaunch.test_launch_claude_through_relayed_provider→ covered bytests/integration/test_ug_claude_relayed.pyTestModelProviderLaunch.test_launch_codex_through_provider→ covered bytest_ug_configure_codex_openai_mps(samemain.ucode.ci_openai_mps)Also removes the now-dead
_first_relayed_servicehelper, theCI_OPENAI_MPS/CI_OPENAI_MODELconstants, thethreadingimport, theCLAUDE_CODE_OAUTH_TOKENwiring in thee2e-shardsjob, and simplifies the codex shard keyword.Why
The integration suite drives the real installed CLI against the same CI MPSes, so these e2e duplicates add no coverage. Each CI run currently burns the personal Anthropic subscription token and the OpenAI-key MPS twice — once from
e2e-shards, once from the integrationfulljob. This removes thee2e-shardshalf; the surviving relayed CUJ lives in the integration suite, which keeps the OAuth-token secret.Merge after #565, which adds
test_ug_claude_relayed.py. This branch is offmain, which doesn't have that integration test yet, so until #565 lands the relayed CUJ has no in-suite coverage. The strict up-to-date ruleset forces a rebase onto post-#565mainbefore merge, which restores the integration relayed coverage at merge time.Test
ruff checkandpy_compileclean; the suite still collects. No behavior change — test and CI-config only.This pull request and its description were written by Isaac.