Skip to content

Make Claude picker ownership crash-safe - #684

Open
andy-xu-db wants to merge 1 commit into
codex/managed-model-locationfrom
codex/claude-picker-ownership
Open

andy-xu-db wants to merge 1 commit into
codex/managed-model-locationfrom
codex/claude-picker-ownership

Conversation

@andy-xu-db

@andy-xu-db andy-xu-db commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

🥞 Stacked PR


Summary

  • Make transitions into and out of managed Claude modelPicker settings transactional across private settings, OS-managed settings, ownership state, and web-search registration.
  • Preserve unrelated user/admin settings, prove legacy ownership before cleanup, and use durable acquisition/revert state for retry-safe crash recovery.
  • Serialize configuration and MCP registration across threads and processes with POSIX- and Windows-compatible advisory locks released before Claude starts.
  • Keep managed-file restoration manifest-first, fail closed on malformed private JSON, and preserve current-main managed smart-routing and OTLP behavior.

Scope boundary

Verification

  • Head: 9642d7aa664c587982d3694ddfd50843e4e9d1f0.
  • Focused final-tip suite: 1,074 passed.
  • Full local stack: 2,540 passed and 42 skipped, excluding the native-binary capture test whose two environment-dependent failures reproduce on main.
  • Independent risk review: SHIP after concurrency, crash-recovery, stack-isolation, and version-gate review.
  • Ruff, formatting, and git diff --check passed.

@andy-xu-db
andy-xu-db force-pushed the codex/claude-picker-ownership branch from b8569ad to 9642d7a Compare September 16, 2026 22:28
@andy-xu-db
andy-xu-db force-pushed the codex/managed-model-location branch from 86d5900 to 64e02bf Compare September 16, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant