fix: handle non-BMP Unicode codepoints in foldl, foldr, and %c format#606
Open
JoshRosen wants to merge 1 commit intodatabricks:masterfrom
Open
fix: handle non-BMP Unicode codepoints in foldl, foldr, and %c format#606JoshRosen wants to merge 1 commit intodatabricks:masterfrom
JoshRosen wants to merge 1 commit intodatabricks:masterfrom
Conversation
foldl/foldr iterated strings by UTF-16 code unit (for (char <- s.value)), splitting non-BMP characters like emoji into surrogate pair halves. Use codePointAt/codePointBefore with Character.charCount for correct codepoint iteration. The %c format conversion used s.toChar.toString which truncates codepoints above U+FFFF to 16 bits. Use Character.toString(s.toInt) instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two more non-BMP Unicode bugs:
for (char <- s.value)), splitting non-BMP characters like emoji into surrogate pair halves. UsecodePointAt/codePointBeforewithCharacter.charCountfor correct codepoint iteration.%cformat conversion useds.toChar.toStringwhich truncates codepoints above U+FFFF to 16 bits. UseCharacter.toString(s.toInt)instead.All code written by Claude Opus 4.6.