[WIP] Porting dbcDeploy on API v2.0#46
Open
MaxGekk wants to merge 7 commits intodatabricks:masterfrom
Open
Conversation
Member
Author
|
@brkyvz @JoshRosen In general, do you agree with the changes? |
brkyvz
reviewed
Mar 25, 2018
build.sbt
Outdated
| scalaVersion := "2.10.4" | ||
| scalaVersion := "2.10.7" | ||
|
|
||
| resolvers += Resolver.bintrayRepo("maxgekk", "maven") |
Contributor
There was a problem hiding this comment.
unfortunately we can't use your repo :(
Contributor
|
@MaxGekk Unfortunately we can't directly link to the library you have developed :/ It needs to be maintained within the databricks org. |
Member
Author
|
@brkyvz In the case if I would include all source code from my library needed to port the plugin on API v2.0 into this PR, it would be ok for you? |
Contributor
|
That works
…On Sun, Mar 25, 2018, 11:56 AM Maxim Gekk ***@***.***> wrote:
@brkyvz <https://github.com/brkyvz> In the case if I would include all
source code from my library needed to port the plugin on API v2.0, it would
be ok for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFACew9xdMrXgD-TYzUKl_WrYlIQShF6ks5th-hDgaJpZM4Spita>
.
|
Member
Author
|
@brkyvz I have included all source codes to the PR. Could you, please, look at CI build. Can we exclude jdk6 and jdk7? |
Contributor
|
We probably can. @gatorsmile and team will now own maintaining this plugin. |
|
Failing for JDK 7, the Base64 functionality isn't part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uploadJar() and attachToCluster() methods are overwritten and ported on REST API v2.0.