[6b/?] feat(python-setup): setup orchestrator (re-land of #2046) - #2063
Merged
Conversation
*Why* #2046 (the setup orchestrator, DECO-27785) shows as MERGED but its code never reached main: it merged into the rugpanov/python-setup-cli-client branch after that branch's PR (#2039) had already been squash-merged, so the orchestrator landed on a stranded branch. This re-lands the reviewed orchestrator directly on main so the feature's first CLI-client caller is actually present (and so the extension-wiring PR can build on it). *What* - Restore PythonSetupEnvironmentSetup + its test verbatim from #2046 as it was reviewed and approved (byte-identical). The orchestrator: gates on isVisible, resolves compute, runs the CLI under a progress indicator with cancellation, and on a ready real-run adopts the venv interpreter + persists state; maps failures to getPythonSetupErrorMessage; coalesces concurrent runs via an in-flight guard. The gate/compute/adopt/persist/progress collaborators are injected seams (wired to real implementations by the extension-wiring PR). *Verification* yarn --cwd packages/databricks-vscode build / test:lint (clean); test:unit 415 passing (VSCODE_TEST_VERSION=1.130.0 -- the default "stable" pulls 1.131.0, whose macOS bundle renames the Electron binary and breaks @vscode/test-electron ^3.0.0 locally, unrelated to this change). Co-authored-by: Isaac
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rclarey
approved these changes
Jul 29, 2026
Contributor
Author
|
🤖 Integration tests triggered for |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#2046 (DECO-27785, the setup orchestrator) shows as MERGED but its code never reached
main. It merged into therugpanov/python-setup-cli-clientbranch after that branch's PR (#2039) had already been squash-merged to main — so the orchestrator landed on a now-stranded branch andmainhas noPythonSetupEnvironmentSetup. This re-lands the reviewed orchestrator directly on main.Without this, the feature's first real
PythonSetupCliClientcaller is missing from main, and the extension-wiring PR (#2054) has nothing to build on.What
PythonSetupEnvironmentSetup+ its test, restored byte-identical from #2046 as reviewed/approved. The orchestrator:isVisible, resolves the compute target, runs the CLI under a progress indicator (with cancellation),getPythonSetupErrorMessage,The gate / compute-resolution / adopt / persist / progress collaborators are injected seams, wired to real implementations by the extension-wiring PR (#2054).
Verification
build+test:lint— clean.test:unit— 415 passing.VSCODE_TEST_VERSION=1.130.0. The default"stable"now pulls VS Code 1.131.0, whose macOS bundle renames the Electron executable toCodeand breaks@vscode/test-electron ^3.0.0locally (spawn … Electron ENOENT). That's a repo-wide test-infra skew, unrelated to this change — flagging it separately.Context
This is a process-recovery PR. Numbered
[6b/?]since it restores what[6/?](#2046) was meant to deliver. DECO-27785.This pull request and its description were written by Isaac.