Repository navigation
Conversation
Signed-off-by: Rashi Jaiswal <rashi.jaiswal@dbtlabs.com>
36 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single transport-level failure of GetOperationStatus (connection reset, timeout) made pollOperation abandon a statement that was still running on the server.
pollOperation now treats a failure with no response as retryable: it keeps polling up to 30 consecutive failures (counter resets on any response), then returns a request error naming the operation and its last known state. HTTP 401/403/404 are not retryable and fail immediately. Responses that carry an error state behave as before. Ported from our fork (dbt-labs#7) onto the
internal/backend/thriftlayout.Other permanent 4xx statuses (for example 400, 410) and 503s that persist are retried up to the 30-failure cap, not failed at once. That is acceptable: the cap bounds the wait to about 30 poll intervals, and the operation is still running server-side, so a brief extra wait is cheaper than abandoning it. 401/403/404 are the cases that cannot recover, so they fail fast.
Independent of the connect-timeout PR from the same fork (it edits backend.go, backend_test.go and CHANGELOG.md in other places, so whichever merges second needs a trivial rebase).
Part of dbt-labs/dbt#16697