Closed
Conversation
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
This was referenced Mar 30, 2026
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
hectorcast-db
left a comment
There was a problem hiding this comment.
Do we need this?
Unlike Go/TF, Python doesn't use the HostType at all.
Contributor
Author
|
The changes were created to have consistency with Go SDK, since we don't need it right now, closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Changes
Add
host_typesupport to the SDK's host metadata discovery flow:host_typefield to theHostMetadatadataclass, parsed from the/.well-known/databricks-configdiscovery endpoint response.HostType.from_api_value()static method to normalize host type strings ("workspace","account","unified") from the API intoHostTypeenum valueswith case-insensitive matching.
Config._resolve_host_metadata(), populate a new_resolved_host_typeattribute from the metadata'shost_typefield (does not overwrite if already set).Tests
HostType.from_api_value()covering all valid values, case variants, unknown strings, empty, andNone.HostMetadata.from_dictwith and withouthost_type._resolve_host_metadatapopulating_resolved_host_type: happy path (unified), no-overwrite, missing metadata, and unknown strings.