Draft
Conversation
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
This was referenced Mar 30, 2026
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
# Conflicts: # databricks-sdk-java/src/main/java/com/databricks/sdk/core/HostType.java
resolve() internally calls tryResolveHostMetadata() which consumes a fixture from the FixtureServer. Tests that then explicitly call resolveHostMetadata() need a second fixture registered to avoid server returning an unexpected response.
resolve() internally calls tryResolveHostMetadata() which already populates resolvedHostType. Remove the redundant explicit calls and revert to single fixtures, except for testResolveHostMetadataDoesNotOverwriteExistingHostType which genuinely needs a second call to verify no-overwrite behavior.
…with FixtureServer Replace real unified.databricks.com hostname with FixtureServer to prevent host metadata resolution from hitting live servers during tests. Co-authored-by: Isaac
Co-authored-by: Isaac
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
changed]
changed]
changed]
Changes
Adds
host_typesupport to host metadata resolution:UNIFIEDvalue to theHostTypeenum for unified hosts that support both workspace and account operationsHostType.fromApiValue()to parse host type strings ("workspace","account","unified") from the/.well-known/databricks-configdiscoveryendpoint
host_typefield toHostMetadatamodelresolvedHostTypefield toDatabricksConfig, populated duringresolveHostMetadata()whenhost_typeis present in the responseAccountClientTesthermetic usingFixtureServerinstead of real hostnamesTests
HostTypeTest: unit tests forfromApiValue()— workspace, account, unified, null, empty, unknownDatabricksConfigTest: integration tests forresolveHostMetadata()populatingresolvedHostTypefor all host types, verifying it doesn't overwrite ifalready set
AccountClientTest: updated to useFixtureServerfor hermetic testing