Sync Azure environment resolution logic with Go SDK#667
Open
hectorcast-db wants to merge 2 commits intomainfrom
Open
Sync Azure environment resolution logic with Go SDK#667hectorcast-db wants to merge 2 commits intomainfrom
hectorcast-db wants to merge 2 commits intomainfrom
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Summary
Unified the Azure environment resolution logic between
getAzureEnvironment()andgetDatabricksEnvironment()to ensure consistent behavior and sync with the Go SDK implementation.Problem
Previously,
getAzureEnvironment()andgetDatabricksEnvironment()had separate, independent logic for resolving Azure environments, which could lead to inconsistent results:getAzureEnvironment()always defaulted to "PUBLIC" and directly calledAzureEnvironment.getEnvironment()getDatabricksEnvironment()had its own Azure environment matching logic that was only triggered whenhost == nullThis divergence meant that
config.getAzureEnvironment()andconfig.getDatabricksEnvironment().getAzureEnvironment()could return different values for the same configuration.Changes
Unified environment resolution:
getAzureEnvironment()now delegates togetDatabricksEnvironment().getAzureEnvironment()instead of maintaining separate logicExpanded Azure environment matching condition: Updated
getDatabricksEnvironment()to trigger Azure environment matching when:azureWorkspaceResourceIdis set ANDhostis null ORazureEnvironmentis explicitly setThis allows users to explicitly override the environment even when a host is configured.
Updated test: Modified
DatabricksAuthManualTest.azureCliUserWithManagementAccessto explicitly setazureEnvironment("PUBLIC")to reflect the new unified behavior.Testing
getAzureEnvironment()andgetDatabricksEnvironment().getAzureEnvironment()