Fix deadlock by completing futures for upfront-fetched chunk links#1101
Merged
jayantsing-db merged 5 commits intoJan 7, 2026
Merged
Conversation
Complete link futures for upfront-fetched chunks to prevent deadlock When chunk links are fetched upfront, the corresponding futures were never completed, causing threads to wait indefinitely. Now we complete these futures in the constructor for all pre-fetched chunks.
nikhilsuri-db
approved these changes
Nov 24, 2025
Collaborator
Author
|
e2e testing that link download service triggers a refresh on expiry when chunk is being downloaded: |
gopalldb
approved these changes
Nov 25, 2025
gopalldb
approved these changes
Dec 10, 2025
Collaborator
Please add testing details |
Collaborator
Author
|
Why are tests failing? |
Collaborator
Author
Done. |
Collaborator
Author
|
Tests are passing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NO_CHANGELOG=true
Complete link futures for upfront-fetched chunks to prevent deadlock
When chunk links are fetched upfront, the corresponding futures were never completed, causing threads to wait indefinitely. Now we complete these futures in the constructor for all pre-fetched chunks.
Testing
Additional Notes to the Reviewer