Skip to content

pr-review skill: ask whether API changes were run on a real workspace #7386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 1 commit into from
Nov 6, 2026
Merged

pr-review skill: ask whether API changes were run on a real workspace #7386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .agents/skills/pr-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ on code the change adds or modifies, not on pre-existing issues next to it.
should include the state after the action (list or print it again after
a sync, a deploy or a migration) and the exact value the change is
about, not just a successful exit.
- The fake server in `libs/testserver` only returns what its handlers were
taught, so a test that records the request, or a handler that echoes a
field back, shows what the CLI sends, not what the API accepts. When the
change sends a new field, a new value format (paths, identifiers,
durations) or a new call to a real API, and no test covering it has
`Cloud = true` (`Cloud` is inherited, so check `out.test.toml`) and the
description does not mention a run against a real workspace, ask whether
it was verified against one.
- Are fixtures readable? Prefer generating archives and other binary
inputs in the test script over committing opaque files.
- Does the test reuse the repo's existing test helpers and scripts, and
Expand Down
Loading