Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/validate/references/job_cluster_whole_reference/DMS=: branch ✅ | main (7adc80d) ❌ | latest (v1.24.0) ❌main (7adc80d): latest (v1.24.0): same output as main (7adc80d) TestAccept/bundle/validate/references/job_cluster_whole_reference/DMS=true: branch ✅ | main (7adc80d) ❌ | latest (v1.24.0) ❌main (7adc80d): latest (v1.24.0): same output as main (7adc80d) |
Collaborator
Integration test reportCommit: af29e37
Top 3 slowest tests (at least 2 minutes):
|
SetDefault only skipped a pure ${...} reference where the pattern ends.
A reference higher up, such as
new_cluster: ${resources.jobs.base.job_clusters[0].new_cluster}, still
failed with "expected a map to index ...workload_type, found string",
because fixed path components do not treat a non-map as a no-match.
Walk the pattern one component at a time and skip a pure reference at
any level; the referenced block gets the default itself.
Co-authored-by: Isaac <no-reply@databricks.com>
pietern
force-pushed
the
pietern/f08-7225-set-default-ref-parent
branch
from
November 4, 2026 10:41
45a3fff to
5fa9cd3
Compare
An error from the key lookup at the end of the pattern is relative to the matched value, but it was prefixed with the parent's path, so the last pattern component was missing from the message. Prefix it with the path of the matched value instead. Also cover the cluster workload_type whole-block reference in the acceptance test. Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
approved these changes
Nov 5, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A
${...}reference to a whole block one level above a default key, such asnew_cluster: ${resources.jobs.base.job_clusters[0].new_cluster}or a clusterworkload_type, failedbundle validatewith "expected a map to index".SetDefaultnow skips such references at any level, and errors it can't skip report the full config path.Why
Follow-up to #7225, which handled references at the leaf only.
Tests
bundle/validate/references/job_cluster_whole_reference.This pull request and its description were written by Isaac.