[pietern]

Changes

BuildCanManage now skips the deploying identity when the top-level permissions section lists it with CAN_MANAGE, as its doc comment already said, and sends every other principal once. Bundles that list the deployer upload their snapshot to a new path once on the next deploy, because the stored principal list changes.

Why

Bug in the snapshot permissions added in #6774.

Tests

• Unit tests in bundle/deploy/snapshot/upload_warning_test.go.
• acceptance/bundle/deploy/immutable/can-manage now lists the deployer once.

This pull request and its description were written by Isaac.

[github-actions]

Commit: 2c28abf07 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

1 tests: regression=1 unreleased=0 coverage=0 failing=0

test	branch	main (e1b8c92)	latest (v1.24.0)
TestAccept/bundle/deploy/immutable/can-manage/DMS=	✅	❌	❌

TestAccept/bundle/deploy/immutable/can-manage/DMS=: branch ✅ | main (e1b8c92) ❌ | latest (v1.24.0) ❌

main (e1b8c92):

acceptance_test.go:1342: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1342
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1083
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:660
        	Error:      	Not equal: 
        	            	expected: "\n=== Deploy with a CAN_MANAGE permission entry\n>>> [CLI] bundle deploy\nCreated internal_immutable_snapshots.immutable\nCreated jobs.my_job\nCreated jobs.my_job.permissions\nFiles: 0 uploaded, 0 deleted\nResources: 3 created, 0 changed, 0 deleted, 0 unchanged\n\n=== Check can_manage_principals sent to the snapshot create API\n>>> print_requests.py //api/2.0/snapshots\n[\n  {\n    \"service_principal_name\": \"[USERNAME]\"\n  },\n  {\n    \"user_name\": \"deco-test-user@databricks.com\"\n  }\n]\n\n>>> [CLI] bundle destroy --auto-approve\nThe following resources will be deleted:\n  delete resources.jobs.my_job\n\nAll files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-immutable-can-manage-[UNIQUE_NAME]/default\n\nDestroy: 1 deleted\n"
        	            	actual  : "\n=== Deploy with a CAN_MANAGE permission entry\n>>> [CLI] bundle deploy\nCreated internal_immutable_snapshots.immutable\nCreated jobs.my_job\nCreated jobs.my_job.permissions\nFiles: 0 uploaded, 0 deleted\nResources: 3 created, 0 changed, 0 deleted, 0 unchanged\n\n=== Check can_manage_principals sent to the snapshot create API\n>>> print_requests.py //api/2.0/snapshots\n[\n  {\n    \"service_principal_name\": \"[USERNAME]\"\n  },\n  {\n    \"service_principal_name\": \"[USERNAME]\"\n  },\n  {\n    \"user_name\": \"deco-test-user@databricks.com\"\n  }\n]\n\n>>> [CLI] bundle destroy --auto-approve\nThe following resources will be deleted:\n  delete resources.jobs.my_job\n\nAll files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-immutable-can-manage-[UNIQUE_NAME]/default\n\nDestroy: 1 deleted\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -16,2 +16,5 @@
        	            	   {
        	            	+    "service_principal_name": "[USERNAME]"
        	            	+  },
        	            	+  {
        	            	     "user_name": "deco-test-user@databricks.com"
        	Test:       	TestAccept/bundle/deploy/immutable/can-manage/DMS=
        	Messages:   	bundle/deploy/immutable/can-manage/output.txt vs /tmp/TestAcceptbundledeployimmutablecan-manageDMS=1072362156/002/output.txt
FAIL

latest (v1.24.0): same output as main (e1b8c92)

[eng-dev-ecosystem-bot]

Integration test report

Commit: 2c28abf

Run: 41864570385

	Env	✅​pass	🙈​skip	Time
✅​	aws linux-2core-8gb	273	15	6:38
✅​	aws-windows-latest-4core-16gb	275	13	5:11
✅​	azure linux-2core-8gb	272	15	5:45
✅​	azure-windows-latest-4core-16gb	274	13	4:56
✅​	gcp linux-2core-8gb	271	16	5:50
✅​	gcp-windows-latest-4core-16gb	273	14	5:50

Top 3 slowest tests (at least 2 minutes):

duration	env	testname
3:40	azure-windows-latest-4core-16gb	TestAccept
3:27	gcp-windows-latest-4core-16gb	TestAccept
3:21	aws-windows-latest-4core-16gb	TestAccept