Repository navigation
[draft] Fix bundle/config/root.go - #7304
Draft
lennartkats-db wants to merge 1 commit into
Draft
lennartkats-db wants to merge 1 commit into
lennartkats-db wants to merge 1 commit into
Conversation
lennartkats-db
added
DABs
Collaborator
Integration test reportCommit: f3d4e44
Top 6 slowest tests (at least 2 minutes):
|
lennartkats-db
added
software-factory
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept a native YAML array for
for_each_task.inputsin job tasks and target overrides. The loader serializes literal arrays as JSON before converting the configuration to the Jobs API type. Existing string inputs remain unchanged.This addresses #2370, which reports that authors must escape a JSON array inside a YAML string.
Verification
bundle/config/TestLoadForEachTaskInputsfailed on base3aa5c9607bff73d3fb18a4c6e63b9f03235f3de7for YAML arrays and passed at headf3d4e44060e4b553b40922b0f1fba5b0c9e43c3f. It covers string arrays, object arrays, empty arrays, existing JSON strings, variable reference strings, API JSON serialization, and a target override.