Skip to content

[draft] Fix bundle/direct/dresources/experiment.go - #7302

Draft
lennartkats-db wants to merge 1 commit into
mainfrom
factory/dabs/3013c1dca491
Draft

lennartkats-db wants to merge 1 commit into
mainfrom
factory/dabs/3013c1dca491

Conversation

@lennartkats-db

Copy link
Copy Markdown
Contributor

Summary

  • Apply added or changed configured MLflow Experiment tags during bundle updates through the supported experiment tag API.
  • Detect local tag changes while continuing to ignore tags generated by the backend.
  • Extend the existing experiment acceptance fixture to assert that adding a tag updates the same experiment.

Why

Issue #6521 reports that a configured tag is ignored when the experiment already exists. Recreating an experiment to apply the tag is destructive for existing runs or traces. The change covers the reported mlflow.workload_creation_policy_id tag and other configured experiment tags.

Verification

  • The host regression for TestExperimentDoUpdateSetsConfiguredTags failed at base 3aa5c9607bff73d3fb18a4c6e63b9f03235f3de7: it read old-policy after an update that requested new-policy. It passed at head aa774f2b0cc7c873d3310879bc39cb7d543fec2f.
  • The acceptance fixture now checks that a bundle redeploy adds a tag and preserves the experiment ID. Current-head CI and a live workspace redeploy have not been verified here.

Separate independent output review was skipped under the pilot policy.

@lennartkats-db lennartkats-db added DABs DABs related issues software-factory PR produced by the software factories task labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Commit: aa774f2b0 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=2 unreleased=0 coverage=0 failing=0

test branch main (66ed6bc) latest (v1.23.0)
TestAccept/bundle/resources/experiments/basic/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/experiments/basic/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/experiments/basic/DMS=: branch ✅ | main (66ed6bc) ❌ | latest (v1.23.0) ❌

main (66ed6bc):

acceptance_test.go:1341: Diff:
        --- bundle/resources/experiments/basic/output.txt
        +++ /tmp/TestAcceptbundleresourcesexperimentsbasicDMS=828381218/002/output.txt
        @@ -168,10 +168,6 @@
             {
               "key": "mlflow.experimentType",
               "value": "MLFLOW_EXPERIMENT"
        -    },
        -    {
        -      "key": "k2",
        -      "value": "v2"
             }
           ]
         }
        
    acceptance_test.go:1341: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1341
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1094
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:659
        	Error:      	Not equal: 
        	            	expected: "update experiments.my_experiment\n\nPlan: 0 to add, 1 to change, 0 to delete, 0 unchanged\n"
        	            	actual  : "Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,2 @@
        	            	-update experiments.my_experiment
        	            	+Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged
        	            	 
        	            	-Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged
        	            	-
        	Test:       	TestAccept/bundle/resources/experiments/basic/DMS=
        	Messages:   	bundle/resources/experiments/basic/out.plan.txt vs /tmp/TestAcceptbundleresourcesexperimentsbasicDMS=828381218/001/out.plan.txt

latest (v1.23.0): same output as main (66ed6bc)

TestAccept/bundle/resources/experiments/basic/DMS=true: branch ✅ | main (66ed6bc) ❌ | latest (v1.23.0) ❌

main (66ed6bc):

acceptance_test.go:1341: Diff:
        --- bundle/resources/experiments/basic/output.txt
        +++ /tmp/TestAcceptbundleresourcesexperimentsbasicDMS=true3803590134/002/output.txt
        @@ -168,10 +168,6 @@
             {
               "key": "mlflow.experimentType",
               "value": "MLFLOW_EXPERIMENT"
        -    },
        -    {
        -      "key": "k2",
        -      "value": "v2"
             }
           ]
         }
        
    acceptance_test.go:1341: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1341
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1094
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:659
        	Error:      	Not equal: 
        	            	expected: "update experiments.my_experiment\n\nPlan: 0 to add, 1 to change, 0 to delete, 0 unchanged\n"
        	            	actual  : "Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,2 @@
        	            	-update experiments.my_experiment
        	            	+Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged
        	            	 
        	            	-Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged
        	            	-
        	Test:       	TestAccept/bundle/resources/experiments/basic/DMS=true
        	Messages:   	bundle/resources/experiments/basic/out.plan.txt vs /tmp/TestAcceptbundleresourcesexperimentsbasicDMS=true3803590134/001/out.plan.txt
FAIL

latest (v1.23.0): same output as main (66ed6bc)

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: aa774f2

Run: 41571369709

Env ❌​FAIL ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 4 280 15 8:43
❌​ aws-windows-latest-4core-16gb 4 282 13 8:40
❌​ azure linux-2core-8gb 26 257 15 29:08
❌​ azure-windows-latest-4core-16gb 4 281 13 8:47
❌​ gcp linux-2core-8gb 4 280 15 8:38
❌​ gcp-windows-latest-4core-16gb 4 282 13 7:35
26 interesting tests: 26 FAIL
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
❌​ TestAccept ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/experiments/basic ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/experiments/basic/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/experiments/basic/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestFsLs ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLs/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsForNonexistingDir ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsForNonexistingDir/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsOnEmptyDir ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsOnEmptyDir/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsOnFile ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsOnFile/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsWithAbsolutePaths ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsLsWithAbsolutePaths/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdir ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdir/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirCreatesIntermediateDirectories ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirCreatesIntermediateDirectories/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenDirectoryAlreadyExists ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenDirectoryAlreadyExists/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenFileExistsAtPath ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenFileExistsAtPath/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsRmEmptyDir ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsRmEmptyDir/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsRmFile ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p
❌​ TestFsRmFile/uc-volumes ✅​p ✅​p ❌​F ✅​p ✅​p ✅​p

@lennartkats-db lennartkats-db added software-factory PR produced by the software factories task and removed software-factory PR produced by the software factories task labels Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues software-factory PR produced by the software factories task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants