Repository navigation
[draft] Fix bundle/direct/dresources/experiment.go - #7302
Draft
lennartkats-db wants to merge 1 commit into
Draft
lennartkats-db wants to merge 1 commit into
lennartkats-db wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/resources/experiments/basic/DMS=: branch ✅ | main (66ed6bc) ❌ | latest (v1.23.0) ❌main (66ed6bc): latest (v1.23.0): same output as main (66ed6bc) TestAccept/bundle/resources/experiments/basic/DMS=true: branch ✅ | main (66ed6bc) ❌ | latest (v1.23.0) ❌main (66ed6bc): latest (v1.23.0): same output as main (66ed6bc) |
Collaborator
Integration test reportCommit: aa774f2
26 interesting tests: 26 FAIL
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #6521 reports that a configured tag is ignored when the experiment already exists. Recreating an experiment to apply the tag is destructive for existing runs or traces. The change covers the reported
mlflow.workload_creation_policy_idtag and other configured experiment tags.Verification
TestExperimentDoUpdateSetsConfiguredTagsfailed at base3aa5c9607bff73d3fb18a4c6e63b9f03235f3de7: it readold-policyafter an update that requestednew-policy. It passed at headaa774f2b0cc7c873d3310879bc39cb7d543fec2f.Separate independent output review was skipped under the pilot policy.