Repository navigation
Conversation
New bundle validate tests for nulls that are meant to remove a value: a resource or a field in a target, a map entry, a list, a field of a task matched by task_key (and job_clusters, job parameters, pipeline clusters), nulls in included files, and target overrides split across included files. Today all of them are ignored. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 7 changed tests (limit=20, 0 not selected) 14 tests: regression=0 unreleased=0 coverage=14 failing=0
|
Collaborator
Integration test reportCommit: 2fe8e29
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New
bundle validatetests underacceptance/bundle/validate/nulls/for nulls that are meant to remove a value. Today every one of them is ignored, and string, int and bool nulls are reported with anexpected a ... value, found nullwarning:targets.dev.resources.jobs.bar: null); a null for a resource the base doesn't have fails withjob not_in_base is not defined;tags.x), lists (email_notifications.on_failure);task_key,job_clustersbyjob_cluster_key, job parameters byname, pipeline clusters bylabel;mode,cluster_id,run_as, variabledefault/lookup);databricks.ymloutside a target, where there is nothing to remove.Why
#7261 makes a null remove the value from the base; its diff of these goldens shows the difference. Related: #7259 records the merge semantics of includes and targets in general.
Tests
New tests only; goldens recorded on main.
This pull request and its description were written by Isaac.