Skip to content

acc: fix flaky selftest/timeout on Windows - #7255

Merged
denik merged 1 commit into
mainfrom
denik/acc-selftest-timeout-2s
Nov 3, 2026
Merged

denik merged 1 commit into
mainfrom
denik/acc-selftest-timeout-2s

Conversation

@denik

@denik denik commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Raise the timeout in acceptance/selftest/timeout from 500ms to 2s. The script still sleeps 4s, so it still checks that the script is killed.

Why

On a slow Windows runner bash did not reach trace sleep 4 within 500ms, so the expected >>> sleep 4 line was missing:

expected: "\n>>> sleep 4\n\nError: Test script killed due to a timeout (500ms)\n"
actual  : "\nError: Test script killed due to a timeout (500ms)\n"

Dashboard: test acceptance.TestAccept/selftest/timeout; error 1044 (Incomplete output, 42 runs).

# 1044, task test (windows, direct)
Error:      	Not equal:
            	expected: "\n>>> sleep 4\n\nError: Test script killed due to a timeout (500ms)\n"
            	actual  : "\nError: Test script killed due to a timeout (500ms)\n"

Tests

Regenerated; passes locally.

This pull request and its description were written by Isaac.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 2faf992f8 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

1 tests: regression=0 unreleased=0 coverage=1 failing=0

test branch main (3aa5c96) latest (v1.23.0)
TestAccept/selftest/timeout ✅ ✅ ✅

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 2faf992

Run: 41436024514

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 281 16 5:30
✅​ aws-windows-latest-4core-16gb 283 14 3:50
✅​ azure linux-2core-8gb 280 16 5:22
✅​ azure-windows-latest-4core-16gb 282 14 3:49
✅​ gcp linux-2core-8gb 281 16 4:52
✅​ gcp-windows-latest-4core-16gb 283 14 3:49
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:44 aws-windows-latest-4core-16gb TestAccept
3:43 gcp-windows-latest-4core-16gb TestAccept
3:39 azure-windows-latest-4core-16gb TestAccept

@denik
denik marked this pull request as ready for review October 29, 2026 17:53
@denik
denik requested a review from a team as a code owner October 29, 2026 17:53
@denik
denik requested a review from rclarey October 29, 2026 17:53
Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik force-pushed the denik/acc-selftest-timeout-2s branch from 471ac18 to 2faf992 Compare November 2, 2026 11:18
@denik
denik added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit c6955d8 Nov 3, 2026
27 checks passed
@denik
denik deleted the denik/acc-selftest-timeout-2s branch November 3, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants