Repository navigation
acc: move fs cp to non-existent directory test to acceptance; add DBFS to testserver - #7251
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
Integration test reportCommit: 8ecdfb8
Top 3 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/acc-fs-cp-nonexistent-dir
branch
from
November 2, 2026 11:17
c1f6551 to
2722360
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
denik
changed the title
…unit test Runs against the testserver locally and a real workspace on cloud, so the fake DBFS is checked against the real API. Co-authored-by: Isaac <no-reply@databricks.com>
… keep the root on recursive delete Co-authored-by: Isaac <no-reply@databricks.com>
shreyas-goenka
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
acceptance/cmd/fs/cp/file-to-nonexistent-dir(Cloud = true) and deleteintegration/cmd/fs.TestFsCpFileToNonExistentDir. The test copies a file with a trailing-slash target into an existing directory (succeeds) and into a missing one (no such directory), for every combination of local, DBFS and UC Volume source and target — the same matrix as the integration test.libs/testserver/dbfs.go):get-status,list,mkdirs,create/add-block/close,readanddelete, in a namespace separate from workspace files, with the status and error codes the DBFS filer maps (RESOURCE_DOES_NOT_EXIST,RESOURCE_ALREADY_EXISTS,IO_ERRORfor a non-empty directory).Why
integration/is deprecated (.agents/rules/testing.md), and the acceptance version also runs locally against the testserver.Dashboard: test integration/cmd/fs.TestFsCpFileToNonExistentDir/uc-volumes_to_uc-volumes (the test being moved).
Tests
acceptance/cmd/fs/dbfs(Cloud = true) runsfscommands against DBFS: a 1.5 MB file round trip (several DBFS blocks), already-exists without--overwrite, missing parent,lsof a file,catof a directory, non-empty and recursiverm.testme-aws, 0 skipped), so the testserver's DBFS matches the real API on these paths.This pull request and its description were written by Isaac.