Repository navigation
acc: Collapse the test table in the regression report comment - #7181
Conversation
The table has a row per test variant, often hundreds, which buries the failure details below it. It now sits in a <details> block summarized by the counts line. The workflow trims an oversized report by splitting it at <details>, so it now always keeps the first block, the table. Co-authored-by: Isaac <no-reply@databricks.com>
|
can you add before/after as a comment there? |
This example seems to have an issue with test selection in general, it should not have selected all auto-migrate tests. (Does not invalidate this PR, it could still be useful) |
Integration test reportCommit: 5d0fedc
Top 7 slowest tests (at least 2 minutes):
|
|
Before/after, using the first rows of the #7094 report (660 rows in the real one). BeforeRegression test reportSelected 14 changed tests (limit=20, 0 not selected) 660 tests: regression=16 unreleased=0 coverage=644 failing=0
TestAccept/bundle/data_quality_monitor/DMS=: branch ✅ | main (aed6702) ❌ | latest (v1.23.0) ❌main (aed6702): latest (v1.23.0): same output as main (aed6702) AfterRegression test reportSelected 14 changed tests (limit=20, 0 not selected) 660 tests: regression=16 unreleased=0 coverage=644 failing=0
|
done in #7181 (comment)
Investigating separately |
Changes
The regression report comment now puts the per-test table in a
<details>block, with the counts line (659 tests: regression=15 ...) as its summary.The workflow trims an oversized report by splitting it at
<details>, so it now always keeps the first block (the table) and drops only failure details.Why
The table has a row per test variant, often hundreds (e.g. #7094), which buries the failure details below it.
Tests
TestRenderRegressionReportto assert the table is wrapped.<details>tags stay balanced.This pull request and its description were written by Isaac.