Repository navigation
acc: remove terraform leftovers from acceptance scripts - #6957
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 136fb02
Top 10 slowest tests (at least 2 minutes):
|
The cloud soft-deletes projects (get returns delete_time), while the testserver returns not found. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Oct 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
janniklasrose
added a commit
that referenced
this pull request
Oct 9, 2026
Follow-up to the review thread on #6957. `title` printed `\n=== <label>` with no trailing newline, relying on a following `trace` (which prepends `\n`) to terminate the header line. When a `title` was instead followed by non-`trace` output the header got mashed onto the next line (e.g. `=== Recorded request bodies{`), and authors worked around the missing newline inconsistently: a bare `echo` after the title, or a literal `\n` appended to the label. Make `title` self-contained by printing its own trailing newline. To keep the common `title`+`trace` output tight (no blank line between the header and the command), `trace` drops its leading newline when it directly follows a `title`; a `trace` after any intervening output still gets its usual separator. This is tracked with an `_after_title` flag that `title` sets, `trace` reads and clears, and a `DEBUG` trap clears before any other top-level command. The trap needs `set -T` because the main script runs in a subshell, and a `FUNCNAME` guard keeps it from firing inside the helpers themselves. Remove the now-redundant workarounds (bare `echo`/`echo ""` after a title, trailing `\n` in labels) and regenerate the acceptance goldens. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes dead Terraform leftovers in acceptance scripts and test.toml files: the bundle.tf.json branch in pipelines/zero-value-fields, the stale local_ssd_count Badness note, and the unused terraform.tfstate replacement in bad_ref_string_to_int. In postgres_projects/recreate, the "terraform doesn't delete it" cleanup is replaced by an assertion that the old project is already gone after recreate (not found locally, soft-deleted with delete_time on cloud); it passes, so there is no leak on direct. Other grep hits (state/, migrate/, config-remote-sync/terraform_state, tfstate helpers) are live migration coverage and kept.
This pull request and its description were written by Isaac.